From 3769f7ed82b2a4a18dfa3b7be705360851f85b0c Mon Sep 17 00:00:00 2001 From: Nihantra Patel Date: Tue, 2 Jun 2026 14:23:41 +0530 Subject: [PATCH 1/3] test: update loan repayment party assertion for payroll payable GL entry --- hrms/payroll/doctype/payroll_entry/test_payroll_entry.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py b/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py index b61b5f8756..76592af570 100644 --- a/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py +++ b/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py @@ -320,8 +320,9 @@ def test_loan_with_settings_disabled(self): [party_type, party] = get_repayment_party_type(loan.name) - self.assertEqual(cstr(party_type), "") - self.assertEqual(cstr(party), "") + # payroll payable GL entries always have party details regardless of employee tagging setting + self.assertEqual(party_type, "Employee") + self.assertEqual(party, applicant) def test_salary_slip_operation_queueing(self): company = "_Test Company" From 1cc849034bd57a5ca2a2d973579b3ffb6b023bdf Mon Sep 17 00:00:00 2001 From: Nihantra Patel Date: Tue, 2 Jun 2026 14:30:51 +0530 Subject: [PATCH 2/3] test: update loan repayment party assertion for payroll payable GL entry --- hrms/payroll/doctype/payroll_entry/test_payroll_entry.py | 1 - 1 file changed, 1 deletion(-) diff --git a/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py b/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py index 76592af570..d83057adf4 100644 --- a/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py +++ b/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py @@ -320,7 +320,6 @@ def test_loan_with_settings_disabled(self): [party_type, party] = get_repayment_party_type(loan.name) - # payroll payable GL entries always have party details regardless of employee tagging setting self.assertEqual(party_type, "Employee") self.assertEqual(party, applicant) From b90d64265c446b0a73a6306eb3c8974065302487 Mon Sep 17 00:00:00 2001 From: Nihantra Patel Date: Tue, 2 Jun 2026 15:32:24 +0530 Subject: [PATCH 3/3] fix: set party_not_required flag for loan repayment GL entries when employee-based accounting is disabled --- hrms/payroll/doctype/payroll_entry/test_payroll_entry.py | 4 ++-- hrms/payroll/doctype/salary_slip/salary_slip_loan_utils.py | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py b/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py index d83057adf4..b61b5f8756 100644 --- a/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py +++ b/hrms/payroll/doctype/payroll_entry/test_payroll_entry.py @@ -320,8 +320,8 @@ def test_loan_with_settings_disabled(self): [party_type, party] = get_repayment_party_type(loan.name) - self.assertEqual(party_type, "Employee") - self.assertEqual(party, applicant) + self.assertEqual(cstr(party_type), "") + self.assertEqual(cstr(party), "") def test_salary_slip_operation_queueing(self): company = "_Test Company" diff --git a/hrms/payroll/doctype/salary_slip/salary_slip_loan_utils.py b/hrms/payroll/doctype/salary_slip/salary_slip_loan_utils.py index f70a02cd6f..b2f88860d9 100644 --- a/hrms/payroll/doctype/salary_slip/salary_slip_loan_utils.py +++ b/hrms/payroll/doctype/salary_slip/salary_slip_loan_utils.py @@ -147,7 +147,12 @@ def make_loan_repayment_entry(doc: "SalarySlip"): ) repayment_entry.save() + + if not process_payroll_accounting_entry_based_on_employee: + frappe.flags.party_not_required = True + repayment_entry.submit() + frappe.flags.party_not_required = False frappe.db.set_value("Salary Slip Loan", loan.name, "loan_repayment_entry", repayment_entry.name)