From d15b86ea03f6a475bfb6ee9379c1876d2bf0b309 Mon Sep 17 00:00:00 2001 From: krystian Date: Sun, 24 May 2026 12:37:03 -0400 Subject: [PATCH] chore(tooling): retire isort dependency --- pyproject.toml | 7 ------- src/probaboracle/doctor_env.py | 1 - tests/test_tooling_contract.py | 12 ++++++++++++ 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 3a48b3e..46a0b03 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -21,7 +21,6 @@ dependencies = [ [project.optional-dependencies] dev = [ "build==1.5.0", - "isort==8.0.1", "mypy==2.1.0", "pip-audit==2.10.0", "pre-commit==4.6.0", @@ -45,12 +44,6 @@ src = ["src", "tests", "scripts"] [tool.ruff.lint] select = ["E", "F", "I", "UP", "B"] -[tool.isort] -profile = "black" -line_length = 88 -src_paths = ["src", "tests"] -known_first_party = ["probaboracle"] - [tool.mypy] python_version = "3.10" mypy_path = "src" diff --git a/src/probaboracle/doctor_env.py b/src/probaboracle/doctor_env.py index 62bb2a8..636ed9d 100644 --- a/src/probaboracle/doctor_env.py +++ b/src/probaboracle/doctor_env.py @@ -92,7 +92,6 @@ def _check_imports() -> int: optional_dev_modules = [ "build", - "isort", "mypy", ] for name in optional_dev_modules: diff --git a/tests/test_tooling_contract.py b/tests/test_tooling_contract.py index b6f62fe..db102b7 100644 --- a/tests/test_tooling_contract.py +++ b/tests/test_tooling_contract.py @@ -67,6 +67,18 @@ def test_runtime_docs_name_the_make_targets(self) -> None: ): self.assertIn(command, docs) + def test_import_sorting_is_owned_by_ruff_not_isort_extension(self) -> None: + pyproject = read("pyproject.toml") + doctor = read("src/probaboracle/doctor_env.py") + + self.assertIn('select = ["E", "F", "I", "UP", "B"]', pyproject) + self.assertIn("ruff check scripts src tests", read("Makefile")) + self.assertIn("ruff format --check scripts src tests", read("Makefile")) + + self.assertNotIn('"isort', pyproject) + self.assertNotIn("[tool.isort]", pyproject) + self.assertNotIn('"isort"', doctor) + if __name__ == "__main__": unittest.main()