Skip to content

fix: validate render IPC payload before spawning renderer #8

@ubugeeei

Description

@ubugeeei

Finding

render:start accepts renderer-provided payload values and directly serializes them into the render process argument string. Width, height, fps, frame count, workers, preset, and ffmpeg threads are not runtime validated in the Electron main process.

Evidence

  • electron/render-settings-preload.ts exposes startRender through contextBridge.
  • electron/main.ts startRenderProcess builds argsString directly from RenderStartPayload.

Acceptance criteria

  • Add main-process validation for render:start payloads.
  • Reject non-finite, unsafe, or out-of-range values before spawning.
  • Keep the preset/encode allowlist explicit.
  • npm run build:electron passes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions