Determine where to begin writing tests and refactoring

[mikefab]

[daiict218]

hi @mikefab, I'm new to open source and have significant experience with React-Redux application. I want to contribute to this project. Please guide me where to start. I've written tests with jest/enzyme and consider myself expert in JS (React/Redux application)

[justwheel]

Hi @daiict218! Welcome to the MagicBox repositories. 👋

Over the last few weeks, @mikefab, @carloscdias, and @rdebeasi made some significant changes to the project in the 2.0_dev branch. Eventually, this will become the newest stable version of the code. However, we have not done a great job of communicating what's next.

We just finished a residency engagement and we're working on getting our GitHub issues and project boards up to date. Hopefully we will have this done during the next week. It may be easier to guide you to something later this week, or unless @mikefab has ideas in mind for this issue.

[daiict218]

Thanks @jflory7, I'm really looking for contributing to unicef with web-dev. I can start working on features as well. This is my stack overflow profile and I want to improve my github profile as well. Let me know once you have some work where I can contribute with.

[thoat]

Hi @jwflory and @mikefab can either of you elaborate more on this when you have the time?

[justwheel]

@thoat In retrospect, this issue is broad and not well-scoped. In January, we didn't have the code health checks set up yet (introduced in #51). I think the feedback from CodeClimate is probably a good place to start for looking at opportunities to refactor.

I think it would also be an awesome stretch goal to look at writing more unit tests to take advantage of CodeClimate's test coverage functionality. Then, the unit tests can be integrated into pull requests to set standards for code coverage (e.g. code base must never be under 75% test coverage).

I think TravisCI can handle the actual unit tests, so long as any new unit tests are integrated into the Node test script, since this is what Travis already uses to run tests on PRs.

Anyways, for this issue, I would suggest closing it and breaking into smaller pieces, and CodeClimate might give some hints for places to start.