Fix (#79) latest report export button behavior on Reports page#171
Fix (#79) latest report export button behavior on Reports page#171Jeshika311 wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Reports page “Export Latest Report” header button to export the newest ready report PDF (instead of a placeholder route), and adds unit tests covering the updated behavior. This PR also introduces an unrelated Scanner catalog retry UX (with a new unit test) and a backend integration test for missing-plugin task starts.
Changes:
- Reports header export button now finds the newest
readyreport and opens its/task/:id/report/pdfURL; disables the button when no ready report exists. - Added unit tests validating header export behavior (newest-ready vs. disabled state).
- Added Scanner catalog “Retry” flow plus a unit test; added a backend integration test for missing plugin start-task behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
frontend/src/pages/Reports.tsx |
Implements “Export Latest Report” behavior using newest ready report and disables when unavailable. |
frontend/testing/unit/pages/Reports.test.tsx |
Adds unit tests for the header export button behavior. |
frontend/src/pages/Toolkit.tsx |
Adds retry mechanism for plugin catalog loading failures. |
frontend/testing/unit/pages/ScannerRetry.test.tsx |
Tests the new Toolkit catalog retry flow. |
testing/backend/integration/test_routes.py |
Adds integration coverage for starting a task with a missing plugin id. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
utksh1
left a comment
There was a problem hiding this comment.
The “export latest report” change is useful, but this PR currently includes unrelated and blocking changes:
- Removes final newline in
testing/backend/integration/test_routes.py(should keep newline) - Modifies backend concurrency limiter tests (unrelated to Reports UI)
- Adds a binary
testout.txtfile (should not be in the repo)
Please remove the unrelated backend/testout changes and keep this PR focused on the Reports page + frontend tests (or split into separate PRs). After that, I can re-review and we can rebase onto the updated Reports filters work.
db36d73 to
928baa6
Compare
|
@utksh1 I’ve removed the unrelated backend/testout changes and cleaned up the PR. |
Description
Updated the Reports page export button behavior by replacing the placeholder latest-report export action with a proper latest ready report export flow.
Changes made:
frontend/src/pages/Reports.tsxRelated Issues
Closes #79
Type of Change
How Has This Been Tested?
Checklist