Added Custom Branding Browser Favicon Logo Support#262
Open
Dhruv-kundu wants to merge 2 commits into
Open
Conversation
Author
|
Hello @utksh1 , Myself Dhruv .
|
utksh1
requested changes
May 23, 2026
Owner
utksh1
left a comment
There was a problem hiding this comment.
Thanks for the branding contribution. I am requesting changes before this can merge.
Why this is not merge-ready yet:
- The favicon file is very large for a browser tab icon:
frontend/favicon.pngis 1024x1024 and about 1.4 MB. A favicon should be optimized and tiny, usually 32x32/48x48 or a small.ico/PNG set. - The image includes detailed text (
SecuScanand the subtitle). That text will be unreadable at favicon size, so the favicon should use a simplified icon-only mark. - The PR says
Closes #197, but #197 asks for broader logo/branding integration across README/docs/UI. This PR only adds browser favicon support, so either complete the requested integration or change the PR wording so it does not close #197. - Please place static favicon assets in the frontend static/public path expected by the Vite build, and verify the built app resolves the icon correctly.
Labels applied: area:frontend, type:design, level:beginner. I did not add gssoc:approved because this needs changes first.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related Issue
Closes #197
program: gssoc
Description
Type of Change
Changes Made
-- Browser Tab Favicon
Benefits
Checklist
Screenshots
Before
After

Testing
Logo Added
