fix(ci): untrack playwright-report artifact and close gitignore/CI guard gaps#285
Open
MehtabSandhu11 wants to merge 1 commit into
Open
Conversation
…s- Remove committed frontend/playwright-report/index.html (518 KB)- Remove committed frontend/test-results/.last-run.json- Add frontend/playwright-report/, frontend/test-results/, frontend/.vite/ to .gitignore so git add rejects them locally before any PR- Fix scripts/check-artifacts.sh to scan already-tracked files via git ls-files, not only PR diffs -- the diff-only check cannot catch artifacts on main- Add .gitattributes with eol=lf for shell scripts to prevent CRLF corruption on Windows checkoutsCloses utksh1#264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #264
frontend/playwright-report/index.html(518 KB) was committed tomaininviolation of CONTRIBUTING.md. The existing CI guard (
check-artifacts.sh) didnot catch it because it only diffs files changed in a PR — it cannot see
artifacts already sitting in the base branch.
Additionally,
frontend/playwright-report/was missing from.gitignore,meaning nothing blocked contributors from staging the file locally before
opening a PR.
Changes
frontend/playwright-report/index.htmlgit rm --cached.gitignorefrontend/playwright-report/,frontend/test-results/,frontend/.vite/scripts/check-artifacts.shgit ls-filescheck (Check 1) to catch already-tracked artifacts, kept existing diff check (Check 2) for new additionsHow Check 1 Works
The new block runs
git ls-files <pattern>for every blocked path. Unlike thediff check,
git ls-filesreports files that are tracked right now — regardlessof which branch introduced them. This closes the blind spot permanently.
Tests Run
bash scripts/check-artifacts.sh→ "All clear!" ✅git ls-files frontend/playwright-report/→ empty ✅git check-ignore frontend/playwright-report/test.html→ path echoed back ✅