PR #104 adds deleteZoneAclRule, which needs a JSON body on DELETE. The current implementation appears to be working around an AWS SDK v1 limitation by signing the request with the existing signer flow and then executing it through a separate Apache CloseableHttpClient using a custom HttpDeleteWithBody. That seems reasonable as a compatibility workaround, but it leaves the transport behavior divergent from the normal AmazonHttpClient path.
We should investigate whether this request can be executed through the same underlying AWS transport stack. If that is not feasible, the custom Apache client path should explicitly mirror the relevant transport configuration used by AmazonHttpClient, including timeout, retry, pooling, proxy, and connection lifecycle behavior, so DELETE-with-body requests behave consistently with the rest of the client.
Right now, that mirroring is not explicit in repo code because VinylDNSClientConfig only carries base URL, credentials, and signer, while VinylDNSClientImpl constructs new ClientConfiguration() for AmazonHttpClient and a separate HttpClients.custom().disableContentCompression().build() for the custom DELETE path.
PR #104 adds
deleteZoneAclRule, which needs a JSON body onDELETE. The current implementation appears to be working around an AWS SDK v1 limitation by signing the request with the existing signer flow and then executing it through a separate ApacheCloseableHttpClientusing a customHttpDeleteWithBody. That seems reasonable as a compatibility workaround, but it leaves the transport behavior divergent from the normalAmazonHttpClientpath.We should investigate whether this request can be executed through the same underlying AWS transport stack. If that is not feasible, the custom Apache client path should explicitly mirror the relevant transport configuration used by
AmazonHttpClient, including timeout, retry, pooling, proxy, and connection lifecycle behavior, soDELETE-with-body requests behave consistently with the rest of the client.Right now, that mirroring is not explicit in repo code because
VinylDNSClientConfigonly carries base URL, credentials, and signer, whileVinylDNSClientImplconstructsnew ClientConfiguration()forAmazonHttpClientand a separateHttpClients.custom().disableContentCompression().build()for the customDELETEpath.