Model and Storage Component still has traces of AB3

[yan-soon]

Both components still have traces of AB3 and not refactored to suit StonksBook. (Eg. Person instead of Contact and AddressBookStorage instead of StonksBookStorage`. Once again, if intended, could be misleading for readers who are also familiar with AB3.

[nus-se-bot]

Team's Response

Prof advised not to rename packages in Luminus announcements. Since we did not change the names of the AB3 related packages, hence the naming of the DG components remain the same.

In addition, there is no need to refactor your packages to match the naming of your product.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

• I disagree

Reason for disagreement: According to the image below, it is written that we can keep our package names the same as AB3, however we should change our class names to reflect what they represent.

Even though Person and Contact can technically be inferred to be the same thing, there are multiple references to both Person and Contact throughout the DG and it can mislead people to think that they are two different classes when they are the referring to the same thing (people stored in StonksBook). I understand if the dev team would want to stick to the Luminus announcement about not renaming, however, to avoid miscommunication, they could have only opted to use either Person or Contact, instead of both, in their DG.

As for AddressBookStorage and StonksBookStorage, since the AddressBookStorage manages storages of Contacts, Sales, Reminders and Meetings, a more appropriate name would be StonksBookStorage as readers would immediately understand that it is the over-arching storage class of the app. However for the name AddressBookStorage, for readers accquainted with the AB3 DG, readers might assume it to be a Storage that only covers the Contacts aspect of the app. For readers that are not accquainted, naming it AddressBookStorage does not suggest the over-arching relationship of the class as well. Thus, I believe that renaming AddressBookStorage to StonksBookStorage here would clear up a lot of confusion.

---