You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are a few issues I've mentioned a while ago on our IRC chat which I thought would be also good to add to Github for convenience.
I've tested and confirmed that they are still present on reader build c65942b
On latest reader version on both Android and iOS there is this issue reproducible in iOS Simulator, Android Emulator and real Android phone. This is for Phones specifically, it might be different on Tablets.
Open EPUB -> try long pressing on any word -> Nothing happens -> Try long pressing again -> Selection Handles Appear, but not Action menu, try dragging one of the selection handles -> Action Menu appears.
Sometimes selection handles do not appear on even 5th long-press selection attempt. Changing page does fix it.
For me a crucial thing here is that it seems that onSetSelectionPopup is not being fired during times when selection handles appear and action bar not. Because I rely on this callback to show my own custom action bar.
Specifically iOS Phone simulator has this issue, iOS Tablet simulator does not. For Android Emulators it happens for Phone and Tablet. And real phone.
Here is iOS user complaining about this on the forums: https://forums.zotero.org/discussion/130845/epub-highlighting-selecting-text-bug-specific-to-ios-mobile-phones/p1
Now this one is only on Android:
Regarding "EPUB: Swipe indicators broken?" EPUB: Swipe indicators broken? zotero-android#305
Indeed, there are a bunch of places in Android’s Jetpack Compose code, where reader’s WebView resides, I catch finger taps. But i do believe that those events are still propagated to the WebView.
To prove that, I’ve made reader_webview_only branch where there is literally nothing but WebView residing in Jetpack Compose ViewTree when you open EPUB. So you will only be able to test swiping and text selection there (but only handles will appear on this branch, not action menu, as custom popup was also removed).
Interesting thing is that if you pinch zoom, then lift one of your fingers, and with remaining finger try swiping you will see a swipe indicator. Oh wait. You are using emulator, then on Mac hold CMD and you will see “Two finger circles” and while pressing left mouse button, move your mouse around the screen and you will see both text resizing and swipe indicators appearing.
To make it easier for you to reproduce this issue please consider installing Android studio and following these instructions:
checkout html_epub2 branch.
open project in Android Studio. It should download everything it needs.
In root of the project run this script scripts/bundle_reader_local.sh It would build reader with all of your local changes and put it into a zip and into the Android project's asset folder. Every time you make changes to reader just re-run this script.
Create an emulator via Android Studio. Any emulator will do. Phone or tablet.
Tap the Green Arrow in Android studio with your emulator selected.
Here are a few issues I've mentioned a while ago on our IRC chat which I thought would be also good to add to Github for convenience.
I've tested and confirmed that they are still present on reader build
c65942bOn latest reader version on both Android and iOS there is this issue reproducible in iOS Simulator, Android Emulator and real Android phone. This is for Phones specifically, it might be different on Tablets.
Sometimes selection handles do not appear on even 5th long-press selection attempt. Changing page does fix it.
For me a crucial thing here is that it seems that onSetSelectionPopup is not being fired during times when selection handles appear and action bar not. Because I rely on this callback to show my own custom action bar.
Specifically iOS Phone simulator has this issue, iOS Tablet simulator does not. For Android Emulators it happens for Phone and Tablet. And real phone.
Here is iOS user complaining about this on the forums:
https://forums.zotero.org/discussion/130845/epub-highlighting-selecting-text-bug-specific-to-ios-mobile-phones/p1
Now this one is only on Android:
Indeed, there are a bunch of places in Android’s Jetpack Compose code, where reader’s WebView resides, I catch finger taps. But i do believe that those events are still propagated to the WebView.
To prove that, I’ve made reader_webview_only branch where there is literally nothing but WebView residing in Jetpack Compose ViewTree when you open EPUB. So you will only be able to test swiping and text selection there (but only handles will appear on this branch, not action menu, as custom popup was also removed).
Interesting thing is that if you pinch zoom, then lift one of your fingers, and with remaining finger try swiping you will see a swipe indicator. Oh wait. You are using emulator, then on Mac hold CMD and you will see “Two finger circles” and while pressing left mouse button, move your mouse around the screen and you will see both text resizing and swipe indicators appearing.
To make it easier for you to reproduce this issue please consider installing Android studio and following these instructions:
html_epub2branch.scripts/bundle_reader_local.shIt would build reader with all of your local changes and put it into a zip and into the Android project's asset folder. Every time you make changes to reader just re-run this script.