From d12929aceec63e3bbee0709321162d279d1107f3 Mon Sep 17 00:00:00 2001 From: Abe Jellinek Date: Wed, 18 Jun 2025 10:28:25 -0400 Subject: [PATCH 1/2] Focus Mode -> Reading Mode --- .../modal-popup/appearance-popup.js | 10 +++--- src/common/components/reader-ui.js | 3 +- src/common/components/toolbar.js | 4 +-- src/common/reader.js | 10 +++--- src/common/types.ts | 8 ++--- .../{focus-mode => reading-mode}/index.ts | 14 ++++---- .../node-mapping.ts | 0 src/dom/snapshot/snapshot-view.ts | 36 +++++++++---------- .../{focus.scss => reading-mode.scss} | 0 9 files changed, 41 insertions(+), 44 deletions(-) rename src/dom/snapshot/{focus-mode => reading-mode}/index.ts (94%) rename src/dom/snapshot/{focus-mode => reading-mode}/node-mapping.ts (100%) rename src/dom/snapshot/stylesheets/{focus.scss => reading-mode.scss} (100%) diff --git a/src/common/components/modal-popup/appearance-popup.js b/src/common/components/modal-popup/appearance-popup.js index 565b6d895..884793556 100644 --- a/src/common/components/modal-popup/appearance-popup.js +++ b/src/common/components/modal-popup/appearance-popup.js @@ -379,19 +379,19 @@ function AppearancePopup(props) {
{type === 'snapshot' && (
- + props.onChangeFocusModeEnabled(e.target.checked)} + id="reading-mode-enabled" + checked={props.viewStats.readingModeEnabled} + onChange={e => props.onChangeReadingModeEnabled(e.target.checked)} />
)} - {(type === 'epub' || props.viewStats.focusModeEnabled) && ( + {(type === 'epub' || props.viewStats.readingModeEnabled) && ( { enableNavigateBack={viewStats.canNavigateBack} enableNavigateToPreviousPage={viewStats.canNavigateToPreviousPage} enableNavigateToNextPage={viewStats.canNavigateToNextPage} + readingModeEnabled={viewStats.readingModeEnabled} appearancePopup={state.appearancePopup} findPopupOpen={findState.popupOpen} themes={state.themes} @@ -234,7 +235,7 @@ const ReaderUI = React.forwardRef((props, ref) => { onChangeSpreadMode={props.onChangeSpreadMode} onChangeFlowMode={props.onChangeFlowMode} onChangeAppearance={props.onChangeAppearance} - onChangeFocusModeEnabled={props.onChangeFocusModeEnabled} + onChangeReadingModeEnabled={props.onChangeReadingModeEnabled} onAddTheme={props.onAddTheme} onChangeTheme={props.onChangeTheme} onOpenThemeContextMenu={props.onOpenThemeContextMenu} diff --git a/src/common/components/toolbar.js b/src/common/components/toolbar.js index 723a1c24c..8dcb51e88 100644 --- a/src/common/components/toolbar.js +++ b/src/common/components/toolbar.js @@ -111,8 +111,8 @@ function Toolbar(props) { className={cx('toolbar-button', { active: props.appearancePopup })} title={l10n.getString('reader-appearance')} tabIndex={-1} - onClick={props.onToggleAppearancePopup} - > + onClick={() => props.onToggleAppearancePopup()} + >{props.readingModeEnabled ? : }
+ {props.type === 'snapshot' && ( + + )} + >