Skip to content

DT-93: Refactor and fix Project Page Settings #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kigiri merged 3 commits into from
Feb 4, 2026
Merged

DT-93: Refactor and fix Project Page Settings #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5739796
refactor: reimplement SettingsPage and adjust API routes.
abdotop Jan 30, 2026
03f554e
feat: Implement detailed project and deployment settings pages with d…
abdotop Jan 31, 2026
831567b
refactor: Migrate settings and deployment pages to `@preact/signals` …
abdotop Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions api/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const defs = {
authorize: withUserSession,
fn: ({ session }) => session,
output: UserDef,
description: 'Handle Google OAuth callback',
description: 'Get current authenticated user information',
}),
'GET/api/picture': route({
fn: (_ctx, { hash }) => getPicture(hash),
Expand Down Expand Up @@ -262,7 +262,7 @@ const defs = {
}),
'GET/api/deployment': route({
authorize: withAdminSession,
fn: async (_ctx, url) => {
fn: async (_ctx, { url }) => {
const dep = DeploymentsCollection.get(url)
Comment on lines +265 to 266
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter name 'url' shadows the imported 'url' from '@01edu/signal-router'. Consider renaming this parameter to 'deploymentUrl' or 'depUrl' to avoid confusion.

Suggested change
fn: async (_ctx, { url }) => {
const dep = DeploymentsCollection.get(url)
fn: async (_ctx, { url: deploymentUrl }) => {
const dep = DeploymentsCollection.get(deploymentUrl)

Copilot uses AI. Check for mistakes.
if (!dep) throw respond.NotFound()
const { tokenSalt, ...deployment } = dep
Expand All @@ -274,7 +274,7 @@ const defs = {
token,
}
},
input: STR(),
input: OBJ({ url: STR('Deployment URL') }),
output: deploymentOutput,
description: 'Get a deployment by ID',
}),
Expand Down Expand Up @@ -316,7 +316,7 @@ const defs = {
output: deploymentOutput,
description: 'Update a deployment by ID',
}),
'GET/api/deployment/token/regenerate': route({
'POST/api/deployment/token/regenerate': route({
authorize: withAdminSession,
fn: async (_ctx, { url }) => {
const dep = DeploymentsCollection.get(url)
Expand Down
2 changes: 1 addition & 1 deletion web/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const App = () => {
<header class='w-full shrink-0 z-0'>
<Header />
</header>
<main class='w-full flex-1 relative'>
<main class='w-full flex-1 flex flex-col relative min-h-0 overflow-hidden'>
{renderPage()}
</main>
</div>
Expand Down
4 changes: 2 additions & 2 deletions web/pages/DeploymentPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,8 +841,8 @@ function TabNavigation({

const logData = api['POST/api/deployment/logs'].signal()
effect(() => {
const { dep, lq } = url.params
if (dep) {
const { dep, lq, sbi } = url.params
if (dep && sbi === 'deployment') {
const filterRows = parseFilters('l').filter((r) =>
r.key !== 'key' && r.value
).map((r) => ({
Expand Down
6 changes: 3 additions & 3 deletions web/pages/ProjectPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { effect } from '@preact/signals'
import { navigate, url } from '@01edu/signal-router'
import { Sidebar } from '../components/SideBar.tsx'
import { user } from '../lib/session.ts'
import { SettingsPage } from './project/SettingsPage.tsx'
import { SettingsPage } from './SettingsPage.tsx'
import { deployments, project, sidebarItems } from '../lib/shared.tsx'

effect(() => {
Expand All @@ -29,9 +29,9 @@ export function ProjectPage() {
}

return (
<div class='drawer lg:drawer-open'>
<div class='drawer lg:drawer-open flex-1 min-h-0'>
<input id='drawer-toggle' type='checkbox' class='drawer-toggle' />
<div class='drawer-content flex flex-col'>
<div class='drawer-content flex flex-col overflow-hidden h-full min-h-0'>
<Component />
</div>
<Sidebar
Expand Down
Loading
Loading