Legacy address and version number fix#341
Open
sasuke0787 wants to merge 12 commits into0LNetworkCommunity:mainfrom
Open
Legacy address and version number fix#341sasuke0787 wants to merge 12 commits into0LNetworkCommunity:mainfrom
sasuke0787 wants to merge 12 commits into0LNetworkCommunity:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Legacy Address Support & Version Number Fix
Changes
This PR addresses two issues:
1. Legacy Address Support
Problem:
Legacy accounts (using v5/16-byte address format) were failing to send transactions. These accounts experienced errors like "INSUFFICIENT_BALANCE_FOR_TRANSACTION_FEE" or "BAD_CHAIN_ID" even when they had sufficient balance.
Solution:
create_sender_with_legacyfunction to centralize legacy address handlingSenderwith the legacy flag--legacy-addressflag for consistencyAffected files:
src-tauri/src/commands/tx.rs- Core transaction functions and legacy supportsrc/components/txs/Transactions.sveltesrc/components/txs/VouchForm.sveltesrc/components/txs/RevokeForm.sveltesrc/components/wallet/MigrationStatus.sveltesrc/components/txs/CwReauthForm.svelte2. Version Number Fix
Problem:
The application was displaying an incorrect version number (1.0.5) instead of the latest version.
Solution:
src-tauri/Cargo.tomland other required filesTesting
Legacy Address Support:
Version Number:
Related Issues
Closes #322
Closes #340