fix(validation): enforce chat and server input limits#183
Open
nyxsky404 wants to merge 1 commit into
Open
Conversation
Contributor
|
@nyxsky404 is attempting to deploy a commit to the Sunil Kumar's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #135
Type of Change
Validation
cd frontend && npm run lintcd frontend && npm run buildcd server && npm start, if backend code changedAdditional checks:
cd server && npm run test:validationcd server && node --check src/routes/chat.jscd server && node --check src/routes/directMessages.jscd server && node --check src/routes/servers.jscd server && node --check src/socket/index.jsScreenshots or Recording
Not included. The UI changes are character counters and validation messages on existing inputs.
Notes for Reviewers
npm startwas not run locally because this workspace does not haveserver/.env/MONGO_URIconfigured.