ethclient: bound tx indexing wait in tests#2211
Open
LarryArnault45 wants to merge 1 commit into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2211 +/- ##
===========================================
- Coverage 52.29% 52.28% -0.01%
===========================================
Files 884 884
Lines 155571 155571
===========================================
- Hits 81355 81343 -12
- Misses 68989 68999 +10
- Partials 5227 5229 +2 see 24 files with indirect coverage changes 🚀 New features to boost your workflow:
|
pratikspatil024
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Adds a bounded wait around the ethclient test backend's transaction indexing poll. The helper now returns a clear setup error if indexing does not complete within 30 seconds instead of allowing the test process to hang until the CI job timeout.
Changes
Breaking changes
None.
Nodes audience
Not applicable; this is a test-only change.
Checklist
Cross repository changes
Testing
Manual tests
gofmt -w ethclient/ethclient_test.gogit diff --check -- ethclient/ethclient_test.gogo test ./ethclientAdditional comments
Test-only change; no runtime behavior changes.