Skip to content

ethclient: bound tx indexing wait in tests#2211

Open
LarryArnault45 wants to merge 1 commit into
0xPolygon:developfrom
LarryArnault45:ethclient-bound-tx-index-wait
Open

ethclient: bound tx indexing wait in tests#2211
LarryArnault45 wants to merge 1 commit into
0xPolygon:developfrom
LarryArnault45:ethclient-bound-tx-index-wait

Conversation

@LarryArnault45
Copy link
Copy Markdown
Contributor

Description

Adds a bounded wait around the ethclient test backend's transaction indexing poll. The helper now returns a clear setup error if indexing does not complete within 30 seconds instead of allowing the test process to hang until the CI job timeout.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

None.

Nodes audience

Not applicable; this is a test-only change.

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

  • gofmt -w ethclient/ethclient_test.go
  • git diff --check -- ethclient/ethclient_test.go
  • go test ./ethclient

Additional comments

Test-only change; no runtime behavior changes.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@pratikspatil024 pratikspatil024 requested a review from a team May 15, 2026 09:15
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.28%. Comparing base (1bf990d) to head (feef1fb).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2211      +/-   ##
===========================================
- Coverage    52.29%   52.28%   -0.01%     
===========================================
  Files          884      884              
  Lines       155571   155571              
===========================================
- Hits         81355    81343      -12     
- Misses       68989    68999      +10     
- Partials      5227     5229       +2     

see 24 files with indirect coverage changes
see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants