chore: pos workspace setup#2218
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
There was a problem hiding this comment.
Pull request overview
This PR sets up PoS workspace conventions by moving AI-agent guidance into a new AGENTS.md, simplifying the PR template, and updating Claude settings, alongside a small Go dependency bump for cmd/keeper.
Changes:
- Bump
golang.org/x/sys(indirect) forcmd/keeper. - Replace the root
CLAUDE.mdcontent with a pointer to the newAGENTS.mdand add Claude web-fetch permissions. - Rewrite the GitHub PR template to a shorter “Summary / Executed tests / Rollout notes” format.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/keeper/go.mod | Bumps golang.org/x/sys indirect dependency. |
| cmd/keeper/go.sum | Updates sums to match the x/sys bump. |
| CLAUDE.md | Replaces the prior guide with an @AGENTS.md pointer. |
| AGENTS.md | Adds the full AI-agent development guide + team standards fetch instructions. |
| .github/pull_request_template.md | Simplifies PR template sections and placeholders. |
| .claude/settings.json | Adds Claude Code settings permitting WebFetch to gist.githubusercontent.com. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Review1 issue found. Checked for bugs and CLAUDE.md compliance. Supply-chain prompt injection riskFile: This block instructs AI agents to fetch and unconditionally apply rules from an external GitHub Gist at the start of every session. Combined with the
If the Gist owner's account is compromised (or even intentionally edited), arbitrary instructions can be injected into every AI agent session on this repo — a blockchain execution client managing real user funds — without any code review. Per the project's own Suggested fix: Vendor the team standards file into the repo (e.g., as |
|
Inline review comment for Supply-chain prompt injection risk: This block instructs AI agents to fetch and unconditionally apply rules from an external GitHub Gist at the start of every session. Combined with the new
If the Gist owner's account is compromised (or even intentionally edited), arbitrary instructions can be injected into every AI agent session on this repo — a blockchain execution client managing real user funds — without any code review. Per the project's own Suggested fix: Vendor the team standards file into the repo (e.g., as |



Description
Init pos workspace setup.