execution/type: Fix invalid RLP encoding of StateSync transactions#149
Open
ngotchac wants to merge 1 commit into
Open
execution/type: Fix invalid RLP encoding of StateSync transactions#149ngotchac wants to merge 1 commit into
ngotchac wants to merge 1 commit into
Conversation
`EncodingSize()` must return the inner size, and not the size of the already RLP-encoded tx. This triggered issues on Blocks sent via the P2P layer which were sending RLP-encoded blocks declared as having 2 or 3 bytes more than the actual data, leading to failures to decode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EncodingSize()must return the inner size, and not the size of the already RLP-encoded tx.This triggered issues on Blocks sent via the P2P layer which were sending RLP-encoded blocks declared as having 2 or 3 bytes more than the actual data, leading to failures to decode.