Skip to content

fix(rpc): prevent memory exhaustion attack in eth_getStorageAt by limit #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xbigapple wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(rpc): prevent memory exhaustion attack in eth_getStorageAt by limit #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions framework/src/main/java/org/tron/core/services/jsonrpc/TronJsonRpcImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,12 @@ private String call(byte[] ownerAddressByte, byte[] contractAddressByte, long va
@Override
public String getStorageAt(String address, String storageIdx, String blockNumOrTag)
throws JsonRpcInvalidParamsException {
if (StringUtils.isBlank(storageIdx)
|| "0x".equalsIgnoreCase(storageIdx)
|| (storageIdx.startsWith("0x") ? storageIdx.length() > 66 : storageIdx.length() > 64)) {
throw new JsonRpcInvalidParamsException("invalid storage index");
}

if (EARLIEST_STR.equalsIgnoreCase(blockNumOrTag)
|| PENDING_STR.equalsIgnoreCase(blockNumOrTag)
|| FINALIZED_STR.equalsIgnoreCase(blockNumOrTag)) {
Expand Down
27 changes: 25 additions & 2 deletions framework/src/test/java/org/tron/core/jsonrpc/JsonrpcServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,26 +525,49 @@ public void testGetStorageAt() {
try {
tronJsonRpc.getStorageAt("", "", "earliest");
Assert.fail("Expected to be thrown");
} catch (Exception e) {
Assert.assertEquals("invalid storage index", e.getMessage());
}

try {
tronJsonRpc.getStorageAt("", "0", "earliest");
Assert.fail("Expected to be thrown");
} catch (Exception e) {
Assert.assertEquals("TAG [earliest | pending | finalized] not supported",
e.getMessage());
}

try {
tronJsonRpc.getStorageAt("", "", "pending");
tronJsonRpc.getStorageAt("", "0", "pending");
Assert.fail("Expected to be thrown");
} catch (Exception e) {
Assert.assertEquals("TAG [earliest | pending | finalized] not supported",
e.getMessage());
}

try {
tronJsonRpc.getStorageAt("", "", "finalized");
tronJsonRpc.getStorageAt("", "0", "finalized");
Assert.fail("Expected to be thrown");
} catch (Exception e) {
Assert.assertEquals("TAG [earliest | pending | finalized] not supported",
e.getMessage());
}

try {
tronJsonRpc.getStorageAt("",
"0x00000000000000000000000000000000000000000000000000000000000000000", "latest");
Assert.fail("Expected to be thrown");
} catch (Exception e) {
Assert.assertEquals("invalid storage index", e.getMessage());
}

try {
tronJsonRpc.getStorageAt("",
"00000000000000000000000000000000000000000000000000000000000000000", "latest");
Assert.fail("Expected to be thrown");
} catch (Exception e) {
Assert.assertEquals("invalid storage index", e.getMessage());
}
}

@Test
Expand Down
Loading