fix: max_tokens limits#244
Conversation
|
@claude review this PR |
|
Claude finished @Lavriz's task —— View job PR Review Complete ✅This PR correctly fixes the token limits issue for Claude models. Here's my detailed review: Review SummaryLGTM - This change properly addresses the API failures by setting correct token limits according to Anthropic's current model specifications. Code AnalysisFixes Applied (
Technical ReviewStrengths:
Code Quality:
Verification Against Anthropic DocsThe token limits align with Anthropic's model specifications:
Minor Observations
RecommendationApprove and merge - This fix resolves the immediate API failures and implements correct token limits according to current Anthropic model specifications. Todo List
|
|
@claude explicitly configure max_tokens for each supported Claude 4 model without using a default value (8_192) since we don't support any other claude models. |
|
Claude finished @Lavriz's task —— View job Todo List
Changes Made ✅
The code now explicitly configures max_tokens for each supported model without relying on any default value. Each Claude 4 model variant has its own explicit configuration as requested. Commit: |
- Remove default max_tokens value (8_192) that was being overridden - Set explicit max_tokens for each supported Claude 4 model variant - Add error handling for unsupported models - Simplify thinking mode configuration logic Co-authored-by: Lavriz <Lavriz@users.noreply.github.com>
|
@Kseymur fixed, thanks!! |
Issue
API requests were failing with:
max_tokens: 128000 > 32000, which is the maximum allowed number of output tokens for claude-opus-4-20250514, #241 (comment)see models limits for input/output, we don't have 128k output anymore.
Changes