THREESCALE-11906: Upgrade to Ruby 3.3 #4129

mayorova · 2025-08-08T08:47:18Z

What this PR does / why we need it:

Because Ruby 3.1 is EOL

Which issue(s) this PR fixes

https://issues.redhat.com/browse/THREESCALE-11906

Verification steps

Special notes for your reviewer:

There was a previous failed attempt to upgrade here: #3864

akostadinov

Maybe we need to update io-console to 0.7.1 to keep it with the default in ruby and avoid native compilation errors on fedora 42.

https://stdgems.org/io-console/

But it's alright to merge as is and try.

jlledom

I doesn't work for me, bundle exec rails assets:clobber assets:precompile fails with this error:

$ bundle exec rails assets:clobber
bin/rails aborted!
ArgumentError: wrong number of arguments (given 3, expected 1..2) (ArgumentError)

  RE_NON_ASCII = Regexp.new('([\x00-\xFF])', Regexp::IGNORECASE, 'n') # [^\0-\177]
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/home/jlledom/redhat/porta/config/application.rb:38:in `<main>'
/home/jlledom/redhat/porta/Rakefile:3:in `require_relative'
/home/jlledom/redhat/porta/Rakefile:3:in `<main>'
bin/rails:4:in `<main>'
(See full trace by running task with --trace)

What I did:

Updated my .tool-versions to point to ruby 3.3
Installed bundler 2.5.22

jlledom · 2025-08-11T12:05:34Z

.tool-versions.sample

-ruby 3.1.5
+ruby 3.3.1
 nodejs 18.20.4
 python 2.7.18


I know it's not related, but, why do we need python?

I believe this was needed for macs, not sure why...
Maybe @josemigallas or @lvillen can confirm whether this is still needed.

It's required by some dependency. A while ago python 3 was made the default in macOS and broke such dependency, so porta could not run.

I doubt anything modern will need python 2.7.18, maybe you need to try again with 3.

jlledom · 2025-08-11T12:09:12Z

Maybe we need to update io-console to 0.7.1 to keep it with the default in ruby and avoid native compilation errors on fedora 42.

https://stdgems.org/io-console/

But it's alright to merge as is and try.

Agree on upgrading io-console. Either here or in another PR

mayorova · 2025-08-11T13:00:23Z

I doesn't work for me, bundle exec rails assets:clobber assets:precompile fails with this error:

RE_NON_ASCII = Regexp.new('([\x00-\xFF])', Regexp::IGNORECASE, 'n') # [^\0-\177]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Yes, there is some other thing needed. And also, this PR is currently blocked by #4130, which is WIP, so this one is also WIP 🙃

jlledom · 2025-09-24T15:28:05Z

@mayorova #4130 is merged, is this reviewable now?

mayorova · 2025-09-25T07:22:01Z

@mayorova #4130 is merged, is this reviewable now?

Nope, it actually depends on #4145

This branch will need to be rebased.

jlledom · 2025-11-25T16:10:28Z

.circleci/config.yml

-system-builder-ruby31: &system-builder-ruby31
-  image: quay.io/3scale/system-builder:5207de2
+system-builder-ruby33: &system-builder-ruby33
+  image: quay.io/3scale/system-builder:ruby-3.3


Where can I see the dockerfile for this?

https://github.com/3scale/system-builder/pull/46/files

jlledom · 2025-11-25T16:13:09Z

lib/developer_portal/config/initializers/liquid_expression_literals_patch.rb

+# This module adds a 'present' literal to the liquid expressions, so that
+# expressions such as the following can be used:
+#    {% if current_account.applications.first == present %}
+# This is required because existing templates use it
+# Previously, this feature was added like this:
+#    Liquid::Expression::LITERALS['present'] = :present?
+# but in the latest Liquid this constant hash is frozen


I trust you, but is this feature tested in the test suite?

mayorova · 2025-11-27T14:51:14Z

Gemfile.lock

    protected_attributes_continued (1.9.0)
      activemodel (>= 5.0)
-    pry (0.13.1)
+    pry (0.15.2)


NameError: undefined method `=~' for class `Pry::Code' (NameError) /home/dmayorov/Projects/3scale/porta/config/application.rb:38:in `<top (required)>'

mayorova · 2025-11-27T14:51:19Z

Gemfile.lock

-      byebug (~> 11.0)
-      pry (~> 0.13.0)
-    pry-doc (1.3.0)
+    pry-byebug (3.11.0)


https://github.com/deivid-rodriguez/pry-byebug/blob/master/CHANGELOG.md#3110-2025-03-28

mayorova · 2025-11-27T14:52:16Z

Gemfile


 gem 'kubeclient'
-
+gem 'nkf'


/home/dmayorov/.asdf/installs/ruby/3.3.1/lib/ruby/gems/3.3.0/gems/bootsnap-1.16.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:32: warning: /home/dmayorov/.asdf/installs/ruby/3.3.1/lib/ruby/3.3.0/kconv.rb is found in nkf, which will no longer be part of the default gems since Ruby 3.4.0. Add nkf to your Gemfile or gemspec. Also contact author of mechanize-2.7.7 to add nkf into its gemspec.

jlledom

It all works for me 👍

qltysh · 2025-12-11T16:26:28Z

❌ 1 blocking issue (3 total)

Tool	Category	Rule	Count
rubocop	Style	Trailing whitespace detected.	1	❌
qlty	Duplication	Found 17 lines of similar code in 2 locations (mass = 85)	2

Gemfile

akostadinov

Looks awesome!

mayorova · 2025-12-30T14:05:49Z

Gemfile.lock

    prism (1.4.0)
-    prometheus-client-mmap (0.28.0)
-      rb_sys (~> 0.9)
+    prometheus-client-mmap (1.3.0)


Needed for Ruby 3.3 support: https://gitlab.com/gitlab-org/ruby/gems/prometheus-client-mmap/-/blob/master/CHANGELOG.md?ref_type=heads#v110

Unfortunately, this is causing issues in midstream builds.

This version requires Rust

Installing prometheus-client-mmap 1.3.0 with native extensions Building native extensions. This could take a while... Bundler::InstallError: Gem::Ext::BuildError: ERROR: Failed to build gem native extension. current directory: /opt/system/vendor/bundle/ruby/3.3.0/gems/prometheus-client-mmap-1.3.0/ext/fast_mmaped_file_rs /usr/bin/ruby -I/usr/share/rubygems extconf.rb checking for rustc... no *** extconf.rb failed *** Could not create Makefile due to some reason, probably lack of necessary libraries and/or headers. Check the mkmf.log file for more details. You may need configuration options. Provided configuration options: --with-opt-dir --without-opt-dir --with-opt-include=${opt-dir}/include --without-opt-include --with-opt-lib=${opt-dir}/lib64 --without-opt-lib --with-make-prog --without-make-prog --srcdir=. --curdir --ruby=/usr/bin/$(RUBY_BASE_NAME) extconf.rb:28:in `<main>': rustc not found. prometheus-client-mmap now requires Rust. (RuntimeError) To see why this extension failed to compile, please check the mkmf.log which can be found here: /opt/system/vendor/bundle/ruby/3.3.0/extensions/x86_64-linux/3.3.0/prometheus-client-mmap-1.3.0/mkmf.log extconf failed, exit code 1 Gem files will remain installed in /opt/system/vendor/bundle/ruby/3.3.0/gems/prometheus-client-mmap-1.3.0 for inspection. Results logged to /opt/system/vendor/bundle/ruby/3.3.0/extensions/x86_64-linux/3.3.0/prometheus-client-mmap-1.3.0/gem_make.out

This can be fixed easily by installing the rust-toolset package.

Rust dependencies are attempted to be installed:

current directory: /opt/system/vendor/bundle/ruby/3.3.0/gems/prometheus-client-mmap-1.3.0/ext/fast_mmaped_file_rs make DESTDIR\= sitearchdir\=./.gem.20251230-1-b9lap2 sitelibdir\=./.gem.20251230-1-b9lap2 cargo rustc --locked --manifest-path ./Cargo.toml --target-dir target --lib --profile release -- -C linker=gcc -L native=/usr/lib64 -C link-arg=-Wl,-z,relro -C link-arg=-Wl,--as-needed -C link-arg=-Wl,-z,now -C link-arg=-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -C link-arg=-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 Updating crates.io index warning: spurious network error (3 tries remaining): [56] Failure when receiving data from the peer (Received HTTP code 403 from proxy after CONNECT) warning: spurious network error (2 tries remaining): [56] Failure when receiving data from the peer (Received HTTP code 403 from proxy after CONNECT) warning: spurious network error (1 tries remaining): [56] Failure when receiving data from the peer (Received HTTP code 403 from proxy after CONNECT) error: failed to get `hashbrown` as a dependency of package `fast_mmaped_file_rs v0.1.0 (/opt/system/vendor/bundle/ruby/3.3.0/gems/prometheus-client-mmap-1.3.0/ext/fast_mmaped_file_rs)` Caused by: download of config.json failed Caused by: failed to download from `https://index.crates.io/config.json` Caused by: [56] Failure when receiving data from the peer (Received HTTP code 403 from proxy after CONNECT) make: *** [Makefile:572: target/release/libfast_mmaped_file_rs.so] Error 101 make failed, exit code 2 Gem files will remain installed in /opt/system/vendor/bundle/ruby/3.3.0/gems/prometheus-client-mmap-1.3.0 for inspection. Results logged to /opt/system/vendor/bundle/ruby/3.3.0/extensions/x86_64-linux/3.3.0/prometheus-client-mmap-1.3.0/gem_make.out /usr/share/rubygems/rubygems/ext/builder.rb:125:in `run' /usr/share/rubygems/rubygems/ext/builder.rb:51:in `block in make' /usr/share/rubygems/rubygems/ext/builder.rb:43:in `each' /usr/share/rubygems/rubygems/ext/builder.rb:43:in `make' /usr/share/rubygems/rubygems/ext/ext_conf_builder.rb:42:in `build' /usr/share/rubygems/rubygems/ext/builder.rb:193:in `build_extension' /usr/share/rubygems/rubygems/ext/builder.rb:227:in `block in build_extensions'

This doesn't work because build environment is hermetic.

mayorova force-pushed the ruby-3.3 branch from 7b7527a to ac70a1a Compare August 8, 2025 08:51

akostadinov previously approved these changes Aug 8, 2025

View reviewed changes

jlledom reviewed Aug 11, 2025

View reviewed changes

mayorova marked this pull request as draft August 11, 2025 13:01

mayorova dismissed akostadinov’s stale review via 0780863 August 14, 2025 10:27

mayorova force-pushed the ruby-3.3 branch 3 times, most recently from b0aa8f2 to cea300a Compare August 14, 2025 15:13

github-actions bot added the Stale label Sep 14, 2025

3scale deleted a comment from github-actions bot Sep 15, 2025

josemigallas removed the Stale label Sep 15, 2025

mayorova mentioned this pull request Sep 16, 2025

THREESCALE-9588: Migrate from sass-rails to dartsass-rails #4145

Merged

github-actions bot added the Stale label Oct 26, 2025

3scale deleted a comment from github-actions bot Oct 26, 2025

github-actions bot removed the Stale label Oct 27, 2025

mayorova force-pushed the ruby-3.3 branch 4 times, most recently from 1eaed14 to f1148a2 Compare November 25, 2025 14:12

jlledom reviewed Nov 25, 2025

View reviewed changes

mayorova mentioned this pull request Nov 25, 2025

Upgrade to Ruby 3.3 3scale/system-builder#46

Open

mayorova force-pushed the ruby-3.3 branch 2 times, most recently from 069db8e to a22b3a3 Compare November 27, 2025 10:48

mayorova mentioned this pull request Nov 27, 2025

THREESCALE-12111: Upgrade Liquid gem #4180

Merged

mayorova force-pushed the ruby-3.3 branch from a22b3a3 to f451ef1 Compare November 27, 2025 12:29

mayorova changed the base branch from master to upgrade-liquid November 27, 2025 12:30

mayorova commented Nov 27, 2025

View reviewed changes

mayorova force-pushed the upgrade-liquid branch 2 times, most recently from 5598a4e to 439ce50 Compare December 4, 2025 14:29

mayorova force-pushed the ruby-3.3 branch from f451ef1 to 6381409 Compare December 5, 2025 16:29

Base automatically changed from upgrade-liquid to master December 9, 2025 16:34

mayorova force-pushed the ruby-3.3 branch from 6381409 to 5d1e69f Compare December 9, 2025 16:35

mayorova marked this pull request as ready for review December 10, 2025 11:58

jlledom previously approved these changes Dec 11, 2025

View reviewed changes

mayorova dismissed jlledom’s stale review via c982a6f December 11, 2025 16:24

mayorova force-pushed the ruby-3.3 branch from c982a6f to c36f8a7 Compare December 11, 2025 16:24

jlledom previously approved these changes Dec 12, 2025

View reviewed changes

mayorova dismissed jlledom’s stale review via f431843 December 16, 2025 10:05

akostadinov reviewed Dec 16, 2025

View reviewed changes

Gemfile Outdated Show resolved Hide resolved

akostadinov previously approved these changes Dec 16, 2025

View reviewed changes

jlledom previously approved these changes Dec 18, 2025

View reviewed changes

mayorova added 7 commits December 19, 2025 16:24

Upgrade Ruby to version 3.3

63d6ce3

Update CircleCI config and the builder image

a4fbc6b

Bump bundler version to 2.5.22

8bcb49c

Update gem dependencies

ba953a3

Fix File.exists?

ca1ba20

Fix email-related tests

6d3fa9e

Fix config.action_dispatch.show_exceptions value

651596d

mayorova dismissed stale reviews from jlledom and akostadinov via 651596d December 19, 2025 15:24

mayorova force-pushed the ruby-3.3 branch from f431843 to 651596d Compare December 19, 2025 15:24

akostadinov approved these changes Dec 19, 2025

View reviewed changes

mayorova commented Dec 30, 2025

View reviewed changes

THREESCALE-11906: Upgrade to Ruby 3.3 #4129

Are you sure you want to change the base?

THREESCALE-11906: Upgrade to Ruby 3.3 #4129

Uh oh!

Conversation

mayorova commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akostadinov left a comment

Choose a reason for hiding this comment

Uh oh!

jlledom left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jlledom commented Aug 11, 2025

Uh oh!

mayorova commented Aug 11, 2025

Uh oh!

jlledom commented Sep 24, 2025

Uh oh!

mayorova commented Sep 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jlledom left a comment

Choose a reason for hiding this comment

Uh oh!

qltysh bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

akostadinov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mayorova commented Aug 8, 2025 •

edited

Loading

jlledom left a comment •

edited

Loading

qltysh bot commented Dec 11, 2025 •

edited

Loading