Take sprockets-rails out of :assets group #4182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixing a regression from #4145
The issue is:
That's because before that PR, while
gem 'sprockets-rails'was inside the:assetsgroup,gem 'sass-rails', now removed, was outside (so, applied globally), and as it hadsprockets-railsas its dependency anyway, it was available everywhere, and enabledconfig.assetsfor Rails configuration.We only need
dartsass-railsandnon-digest-assetsfor example at the assets precompiling stage. However,sprockets-railsis needed in production too, as it actually implements the logic of serving the assets, so I have moved it accordingly.Which issue(s) this PR fixes
-none-
Verification steps
Building with
openshift/system/Dockerfileshould work.Special notes for your reviewer: