Skip to content

Conversation

@josemigallas
Copy link
Contributor

@josemigallas josemigallas commented Dec 10, 2025

THREESCALE-12112: Remove legacy styles in Dashboard

  • Uses PF4 styles and components when possible
  • Removes redundant classes, styles, stylesheets
  • Simplifies widgets

⚠️ Styling and logic should work as always.
Most scenarios have been tested but inevitably some changes might have been introduced, some stuff might have been lost. ⚠️

Before
Screenshot 2025-12-10 at 10 34 45

After
Screenshot 2025-12-10 at 10 32 19

* Uses PF4 styles and components when possible
* Removes redundant classes, styles, stylesheets
* Simplifies widgets
@josemigallas josemigallas self-assigned this Dec 10, 2025
@josemigallas josemigallas requested review from a team and lvillen December 10, 2025 09:35
@qltysh
Copy link

qltysh bot commented Dec 10, 2025

❌ 28 blocking issues (30 total)

Tool Category Rule Count
eslint Lint Unsafe assignment of an any value. 7
reek Lint Provider::Admin::Dashboards::AudienceNavigationPresenter#link_to refers to 'options' more than self (maybe move it to another class?) 6
reek Lint Provider::Admin::Dashboards::AudienceNavigationPresenterTest assumes too much for instance variable '@Provider' 4
eslint Lint Unsafe call of an any typed value. 2
eslint Lint Unsafe return of an any typed value. 2
reek Lint Provider::Admin::Dashboards::DashboardPresenter has at least 7 instance variables 2
stylelint Style Incorrect formatting, autoformat by running qlty fmt. 1
stylelint Lint Expected "geometricPrecision" to be "geometricprecision" (value-keyword-case) 1
reek Lint Provider::Admin::Dashboards::AudienceNavigationPresenter#t has the name 't' 1
rubocop Lint Assignment Branch Condition size for initialize is too high. [<12, 17, 3> 21.02/20] 1
reek Lint Provider::Admin::Dashboards::AudienceNavigationPresenterTest#setup_messages_mocks has approx 10 statements 1
qlty Duplication Found 82 lines of similar code in 2 locations (mass = 296) 2

@qltysh one-click actions:

  • Auto-fix formatting (qlty fmt && git push)

Copy link
Contributor

@jlledom jlledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. The major issue I see is the regression on the messages query limiting

@josemigallas josemigallas requested a review from jlledom December 18, 2025 08:58
Copy link
Contributor

@jlledom jlledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A unit test is failing. looks legit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants