Open
Conversation
- Use context managers for all SQLite connections - Add temp file cleanup in report download endpoint - Add finally blocks for file handle cleanup in simulation runner
Author
VerificationAll checks pass on merged code:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withcontext managers for all SQLite connections in simulation.py, simulation_runner.py, and simulation scripts@after_this_requesttemp file cleanup in report download endpointfinallyblock for file handle safety in simulation runner subprocess creationTest plan
cd backend && uv run python -c "from app import create_app; create_app()"