Skip to content

perf: inline optional getArg in BasicSourceMapConsumer constructor #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7rulnik merged 1 commit into from
May 10, 2026
Merged

perf: inline optional getArg in BasicSourceMapConsumer constructor #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/source-map-consumer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,12 +332,13 @@ function BasicSourceMapConsumer(aSourceMap, aSourceMapURL) {
var version = util.getArg(sourceMap, 'version');
var sources = util.getArg(sourceMap, 'sources');
// Sass 3.3 leaves out the 'names' array, so we deviate from the spec (which
// requires the array) to play nice here.
var names = util.getArg(sourceMap, 'names', []);
var sourceRoot = util.getArg(sourceMap, 'sourceRoot', null);
var sourcesContent = util.getArg(sourceMap, 'sourcesContent', null);
// requires the array) to play nice here. Inlined getArg with default for
// the optional fields below — see #59 for the pattern.
var names = sourceMap.names != null ? sourceMap.names : [];
var sourceRoot = sourceMap.sourceRoot != null ? sourceMap.sourceRoot : null;
var sourcesContent = sourceMap.sourcesContent != null ? sourceMap.sourcesContent : null;
var mappings = util.getArg(sourceMap, 'mappings');
var file = util.getArg(sourceMap, 'file', null);
var file = sourceMap.file != null ? sourceMap.file : null;

// Once again, Sass deviates from the spec and supplies the version as a
// string rather than a number, so we use loose equality checking here.
Expand Down
Loading