perf: inline GLB binary search in generatedPositionFor cold path#68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
generatedPositionFormisses the per-source warm cache and bias is GLB (the default), it falls through to_findMapping→binarySearch.search→iterativeSearch→compareByOriginalPositions. Profiling againstbabel.min.js.mapshowediterativeSearchat 64% self-time for random gpf probes — driven by the indirectaComparecallback at every step and the per-call{source, originalLine, originalColumn}needle allocation.This PR inlines a GLB binary search with direct field access on
mappings[mid]for the GLB cold path. The structure mirrors whatgeneratedPositionForalready uses inside its cache-hit branch (source-map-consumer.js:1088-1112). LUB queries still go through_findMappingunchanged.Results
bench-diff vs
main, SOLO, scoped to genpos phases:CPU profile after the change confirms
iterativeSearchis no longer in the top frames for the gpf scenario.Test plan
yarn test— 205/205 non-TODO tests pass; the 8 failures are pre-existing# TODOitems unrelated to this changebench-diff.sh main trace— full phase set on babel: only Generated Positions speed shifts; everything else within noise