perf: inline base64VLQ.decode slow path in _parseMappings#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_parseMappingshad one call site forbase64VLQ.decode— the multi-byte VLQ slow path inside the inner decode loop — but the call site stayed boxed even after PRs #72 / #73 demonstrated that the function-call overhead at hot dispatch sites can be much larger than the profile's self-time share suggests. Inlining the body removes:.value/.restwrite/read round trip (and thetemp = {}allocation at parse start),fromVLQSignedcall,so the slow path stays in
_parseMappings's frame and V8 can specialize across the call boundary.The
base64DecodeTable(=base64.charToIntMap) is now imported directly insource-map-consumer.js, paralleling the_names._arraydirect-index pattern from PR #67.Results (bench-diff vs main, SOLO)
babel.min.js.map (full-phase, single run)
Three init-only runs reproduce: Init JSON +2.6% / +3.3% / +4.0%, Init Object +0.9% / +1.8% / +1.9%. The full-phase run is higher (+5–9%) likely because of V8 IC sharing — once the parse function is simpler, downstream callers warm up cleaner.
vscode.map (init only, 3 runs)
Very small / neutral on vscode. babel's win comes from cleaner VLQ distribution; vscode is more memory-bound.
Test plan
yarn test— 205/205 non-TODO tests pass