feat: add self update command#450
Open
JosiahParry wants to merge 2 commits into
Open
Conversation
JosiahParry
commented
May 5, 2026
Keats
requested changes
May 6, 2026
Collaborator
Keats
left a comment
There was a problem hiding this comment.
What does it show if the user is not allowed to write to where the binary is?
| ctrlc = { version = "3", optional = true, features = ["termination"] } | ||
| libc = "0.2.172" | ||
| taplo = "0.14.0" | ||
| self_update = {version = "0.44", optional = true, features = ["archive-tar", "compression-flate2"] } |
Collaborator
There was a problem hiding this comment.
can you use the ureq and rustls feature? We already use those elsewhere
Author
|
For testing a non-writable path, do you have an idea how to test that? My thinking is make rv rwx for root then run as subuser on linux with only rx permissions. Does that sound right? |
Collaborator
|
Yep sounds good. It doesn't need to be a test in the repo, it can just be a test you make locally |
Member
|
yep - the context is enterprise customers install rv to like /usr/local/bin/rv then if a user attempts to run that it should fail gracefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
selfsub command to create arv self updateakin touv self updateandjuliaup self update.This is motivated by wanted to get recent and up to date changes from rv but having to go to the repo, then copying the install script, then pasting.