Fix #248: fix legacy manufacturing cost for gun ammo crates#253
Open
Ally-for-Hire wants to merge 1 commit intoACE-Project-Team:devfrom
Open
Fix #248: fix legacy manufacturing cost for gun ammo crates#253Ally-for-Hire wants to merge 1 commit intoACE-Project-Team:devfrom
Ally-for-Hire wants to merge 1 commit intoACE-Project-Team:devfrom
Conversation
Ally-for-Hire
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248.
Gun ammo crates now use their dedicated legacy manufacturing-cost calculation instead of sometimes falling back to the generic
ACEPointsvalue. This restores proper manufacturing cost reporting for gun ammo, while leaving existing missile behavior intact.What Changed
ACE_GetEntLegacyCost()to avoid returning early froment.ACEPointsforacf_ammo.Why This Was Broken
Ammo crates already populate
ACEPoints, andACE_GetEntLegacyCost()was returning that value before it ever reached the ammo-specific manufacturing-cost logic. That meant gun ammo could report a generic legacy points value instead of its actual manufacturing cost.Missiles still appeared correct because their path already aligned with the existing ammo handling.