Fix #249: refine contraption armor direction scanning#254
Open
Ally-for-Hire wants to merge 1 commit intoACE-Project-Team:devfrom
Open
Fix #249: refine contraption armor direction scanning#254Ally-for-Hire wants to merge 1 commit intoACE-Project-Team:devfrom
Ally-for-Hire wants to merge 1 commit intoACE-Project-Team:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249.
Refines contraption front/side armor direction scanning to be more consistent, less dependent on arbitrary entity choice, and harder to mislead with unusual layouts.
What Changed
TracePaddingtoACE.ArmorScanConfig.Why
The previous approach was too easy to skew with arbitrary entity placement, single-entity orientation, or short trace distances. This pass is meant to make the scan quieter and more predictable so normal builds do not notice it, while still behaving reasonably on awkward or missile-heavy contraptions.
NEEDS IN-GAME TESTING AND VERIFICATION, I'M LIABLE TO MISSING THINGS