Salt facility#63
Closed
hettlage wants to merge 176 commits intoAEONplus:mainfrom
Closed
Conversation
…s than or equal to relations
The rationale is that the same validation should be applied to a reference star and hence its code should be as reusable as possible.
It seems that pydantic_settings 2.14 did not pick up environment variable values.
# Conflicts: # uv.lock
Contributor
|
Hi Chris, What can I say, this is incredible! A few questions:
I'll start reviewing the code, but from the looks of this it's nicely modularized to the salt module. Great job. |
Contributor
Author
|
I unfortunately have to close this PR, as I spotted an issue. I will reopen it later this evening. |
Fingel
reviewed
May 7, 2026
| @@ -0,0 +1,66 @@ | |||
| from typing import Literal | |||
|
|
|||
| RssImagingFilter = Literal[ | |||
Contributor
There was a problem hiding this comment.
Is it possible to generate this list from an outside source, like how the OCS modules generate their filter lists, etc? Or if it 's not possible, any plans? Or maybe the instrument setups don't change enough to warrant it?
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "environ({'COMMAND_MODE': 'unix2003', 'TERM_SESSION_ID': 'ec268349-b3f9-4a8d-b0e0-bc976fb4745d', 'SHELL': '/bin/zsh', 'TMPDIR': '/var/folders/3l/v9_k6g5s1174c0nz5dz00jv80000gn/T/', '__CFBundleIdentifier': 'com.jetbrains.pycharm', 'ENABLE_IDE_INTEGRATION': 'true', 'JEDITERM_SOURCE_ARGS': '', 'HOME': '/Users/christian', 'PATH': '/Users/christian/IdeaProjects/AEONlib/.venv/bin:/Users/christian/.bun/bin:/Users/christian/.pyenv/shims:/Users/christian/Documents/Scripts:/Library/PostgreSQL/13/bin:/usr/local/Cellar/bash/5.2.21/bin:/usr/local/opt/mysql-client@5.7/bin:/usr/local/opt/llvm/bin:/usr/local/Cellar/postgresql@18/18.3/bin:/Library/Frameworks/Python.framework/Versions/3.13/bin:/Library/Frameworks/Python.framework/Versions/3.11/bin:/Library/Frameworks/Python.framework/Versions/2.7/bin:/Library/Frameworks/Python.framework/Versions/3.7/bin:/Library/Frameworks/Python.framework/Versions/3.9/bin:/Library/Frameworks/Python.framework/Versions/3.8/bin:/Users/christian/.deno/bin:/Users/christian/.langflow/uv:/Users/christian/.pyenv/bin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/pkg/env/active/bin:/opt/pmk/env/global/bin:/Library/Apple/usr/bin:/usr/local/MacGPG2/bin:/usr/local/go/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Applications/quarto/bin:/Users/christian/.wasmedge/bin:/Users/christian/.cargo/bin:/Users/christian/.local/bin:/usr/local/bin:/Users/christian/.orbstack/bin', 'PROCESS_LAUNCHED_BY_Q': '1', 'LOGNAME': 'christian', 'TERM': 'xterm-color', 'OSLogRateLimit': '64', 'XPC_FLAGS': '0x0', '__CF_USER_TEXT_ENCODING': '0x1F5:0x0:0x0', 'LC_CTYPE': 'UTF-8', 'JEDITERM_SOURCE': '/Users/christian/IdeaProjects/AEONlib/.venv/bin/activate', 'FIG_TERM': '1', 'SSH_AUTH_SOCK': '/var/run/com.apple.launchd.sz8hMP8NFm/Listeners', 'CLAUDE_CODE_SSE_PORT': '65516', 'XPC_SERVICE_NAME': '0', 'USER': 'christian', 'TERMINAL_EMULATOR': 'JetBrains-JediTerm', 'PROCESS_LAUNCHED_BY_CW': '1', 'SHLVL': '1', 'PWD': '/Users/christian/IdeaProjects/AEONlib', 'OLDPWD': '/Users/christian/IdeaProjects/AEONlib', 'DYLD_LIBRARY_PATH': '/Users/christian/.wasmedge/lib', 'LIBRARY_PATH': '/Users/christian/.wasmedge/lib', 'C_INCLUDE_PATH': '/Users/christian/.wasmedge/include', 'CPLUS_INCLUDE_PATH': '/Users/christian/.wasmedge/include', 'LANG': 'C.UTF-8', 'PYENV_ROOT': '/Users/christian/.pyenv', 'ZSH': '/Users/christian/.oh-my-zsh', 'PAGER': 'cat', 'LESS': '-R', 'LSCOLORS': 'Gxfxcxdxbxegedabagacad', 'LS_COLORS': 'di=1;36:ln=35:so=32:pi=33:ex=31:bd=34;46:cd=34;43:su=30;41:sg=30;46:tw=30;42:ow=30;43', 'VIRTUAL_ENV_DISABLE_PROMPT': '1', 'JAVA_HOME': '/Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home', 'NVM_DIR': '/Users/christian/.nvm', 'NVM_CD_FLAGS': '-q', 'PYENV_SHELL': 'zsh', 'BUN_INSTALL': '/Users/christian/.bun', 'VIRTUAL_ENV': '/Users/christian/IdeaProjects/AEONlib/.venv', 'VIRTUAL_ENV_PROMPT': 'aeonlib', '_': '/Users/christian/IdeaProjects/AEONlib/.venv/bin/jupyter', 'JPY_SESSION_NAME': '/Users/christian/IdeaProjects/AEONlib/examples/SALT.ipynb', 'JPY_PARENT_PID': '82763', 'PYDEVD_USE_FRAME_EVAL': 'NO', 'CLICOLOR': '1', 'FORCE_COLOR': '1', 'CLICOLOR_FORCE': '1', 'GIT_PAGER': 'cat', 'MPLBACKEND': 'module://matplotlib_inline.backend_inline', 'SALT_USERNAME': 'ariba', 'SALT_PASSWORD': 'lookingup'})\n" |
Contributor
OK, I submitted my two comments that I got to, I'll look forward to the revised pr later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the Southern African Large Telescope.