[WIP] One more code checking during the block validation if the previous code checking was failed.#3328
Open
EanCuznaivy wants to merge 1 commit intodevfrom
Open
[WIP] One more code checking during the block validation if the previous code checking was failed.#3328EanCuznaivy wants to merge 1 commit intodevfrom
EanCuznaivy wants to merge 1 commit intodevfrom
Conversation
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. No other active qualified developers found to review these specific changes. You might consider involving more team members with these code segments. Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time. (click to collapse)
Committed file ranks(click to expand)66.78%[...src/AElf.Kernel.CodeCheck/Application/CodeCheckValidation] |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #3328 +/- ##
==========================================
- Coverage 89.24% 89.23% -0.01%
==========================================
Files 629 629
Lines 25154 25156 +2
Branches 2210 2210
==========================================
Hits 22448 22448
- Misses 2442 2444 +2
Partials 264 264
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure of previous code checking was probably due to the aelf node still in an old version. One more code checking will help this aelf node sync new blocks as expected.