Conversation
vasmohi
commented
Sep 27, 2024
vasmohi
commented
- Added aelf-samples submodule to aelf-developer-tools
- Added Todo, TicTacToe & ExpenseTracker smart contract templates to aelf-developer-tools
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestNo commonly committed files found with a 40% threashold Committed file ranks(click to expand)0.00%[templates/TicTacToeContract/test/TicTacToe.Tests.csproj] 0.00%[templates/ToDoContract/src/ToDo.csproj] 0.00%[templates/ExpenseTrackerContract/src/.DS_Store] 0.00%[templates/TicTacToeContract/src/TicTacToe.csproj] 0.00%[templates/ExpenseTrackerContract/src/ExpenseTrackerState.cs] 0.00%[templates/ExpenseTrackerContract/.DS_Store] 0.00%[...templates/ExpenseTrackerContract/test/ExpenseTrackerTests] 0.00%[...templates/ToDoContract/test/Protobuf/stub/hello_world_con] 0.00%[...templates/TicTacToeContract/src/Protobuf/contract/hello_w] 0.00%[templates/ToDoContract/test/_Setup.cs] |
| on: | ||
| push: | ||
| tags: | ||
| - 'aelf-samples-v*' |
There was a problem hiding this comment.
This file should not exists. Basically when someone puts up a template tag with version, it should also pack all aelf-samples contract into the contract template package.
There was a problem hiding this comment.
Removed prod-workflow
| <Content Include="LotteryGameContract\**\*" Exclude="LotteryGameContract\**\bin\**;LotteryGameContract\**\obj\**" /> | ||
| <Content Include="SimpleDAOContract\**\*" Exclude="SimpleDAOContract\**\bin\**;SimpleDAOContract\**\obj\**" /> | ||
| <Content Include="NftSaleContract\**\*" Exclude="NftSaleContract\**\bin\**;NftSaleContract\**\obj\**" /> | ||
| <Content Include="ToDoContract\**\*" Exclude="ToDoContract\**\bin\**;ToDoContract\**\obj\**" /> |
There was a problem hiding this comment.
These should be removed and instead be read from the aelf-sample submodule
There was a problem hiding this comment.
Configured to fetch from aelf-samples
| @@ -0,0 +1,21 @@ | |||
| { | |||
| "$schema": "http://json.schemastore.org/template", | |||
There was a problem hiding this comment.
All these should be added into aelf-samples repo to maintain consistency
There was a problem hiding this comment.
Added to aelf-samples
…les prod workflow
2 participants
