Skip to content

Fix activity center collapse anchoring#33

Merged
cuesurfbot merged 1 commit into
mainfrom
codex/activity-banner-anchor
May 19, 2026
Merged

Fix activity center collapse anchoring#33
cuesurfbot merged 1 commit into
mainfrom
codex/activity-banner-anchor

Conversation

@zzj3720
Copy link
Copy Markdown
Contributor

@zzj3720 zzj3720 commented May 19, 2026

Summary

  • keep the activity center banner top-anchored while its body collapses so the title does not drop
  • preserve the reserved activity-center height while collapsed and avoid exposing the bottom safe-area padding after collapse
  • use explicit exit distance so collapsed banners dismiss below the viewport
  • let the anchor shrink again when open content becomes shorter
  • add focused layout helper coverage for collapse anchoring, shrink, and exit behavior

Validation

  • node .yarn/releases/yarn-4.9.1.cjs typecheck
  • node .yarn/releases/yarn-4.9.1.cjs test
  • node .yarn/releases/yarn-4.9.1.cjs lint
  • node .yarn/releases/yarn-4.9.1.cjs build:embedded (passes with existing asset size warnings)
  • manual geometry smoke: expanded/collapsed top both 660px in a 900px viewport; collapsed exit bottom reaches 1016px; open content shrink moves top from 660px to 780px

Co-authored-by: 3720 <zuozijian1994@gmail.com>
@zzj3720 zzj3720 force-pushed the codex/activity-banner-anchor branch from 3024b37 to b5376a6 Compare May 19, 2026 10:38
Copy link
Copy Markdown
Contributor

@cuesurfbot cuesurfbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 上一轮提的 exit 位移和 anchor only-grow 都修了:exit 显式用 anchorHeight + safeArea + exitOffset 推出屏幕,anchor 在 open 时直接同步 measured、close 时才保留 prev。helper 测试也补到了。CI 全绿。

@cuesurfbot cuesurfbot marked this pull request as ready for review May 19, 2026 11:26
@cuesurfbot cuesurfbot merged commit e3446d0 into main May 19, 2026
3 checks passed
@cuesurfbot cuesurfbot deleted the codex/activity-banner-anchor branch May 19, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants