Skip to content

Feature/object detector with aruco marker#5

Merged
AntoniRL merged 38 commits intohumble-develfrom
feature/object-detector
Apr 9, 2026
Merged

Feature/object detector with aruco marker#5
AntoniRL merged 38 commits intohumble-develfrom
feature/object-detector

Conversation

@AntoniRL
Copy link
Copy Markdown
Contributor

@AntoniRL AntoniRL commented Mar 24, 2026

Description

Added a service that returns a list of detected blocks marked with ArUco markers.

Motivation and Context

This is the first step to obtain the object position for RL algorithms. Later, it will be replaced with detection using a neural network.

How Has This Been Tested?

Tested with the real robot, and with two test scripts.

Realted PR

Checklist:

  • All TODOs in the code has been resolved or linked with a proper issue.
  • Code is (auto)formatted.
  • Documentation (README/CHANGELOG/Wiki/etc) has been updated.
  • All automatic checks passed.

Clickup task: 869cbbrjb

Copy link
Copy Markdown
Contributor

@macmacal macmacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the starters, please update the CHANGELOG

@macmacal
Copy link
Copy Markdown
Contributor

To enforce the new ruleset for merging PRs i needed to update the CICD with #6 . Please pull the humble-devel and push anything - the pre-commit (prek) job should start automatically.

Copy link
Copy Markdown

@sivral sivral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AntoniRL AntoniRL requested a review from macmacal April 9, 2026 12:56
Copy link
Copy Markdown
Contributor

@macmacal macmacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🆗

@AntoniRL AntoniRL merged commit e028dc9 into humble-devel Apr 9, 2026
1 check passed
@AntoniRL AntoniRL deleted the feature/object-detector branch April 9, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants