Preserve crossfade precision, use per-scene temp assets, and dedupe line-trend chart#483
Open
AJaySi wants to merge 1 commit into
Open
Preserve crossfade precision, use per-scene temp assets, and dedupe line-trend chart#483AJaySi wants to merge 1 commit into
AJaySi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fade_durprecisely./tmp/*.pngintermediate filenames with unique, per-scene asset paths.make_line_trendimplementation and keep a single canonical, configurable version to avoid divergence and enable marker/area options.Description
crossfade_concatto callconcatenate_videoclips(..., padding=-fade_dur)to preserve float precision for crossfade padding.temp_dirthroughdispatch_scene,build_data_scene, andbuild_bullet_sceneso chart/overlay assets are written into a job-specific directory.make_line_trendand kept the canonical version which acceptsshow_areaandshow_markersoptions.pipeline_from_jsonto create a per-scene temp directory and pass it intodispatch_scene.BrollService.generate_scene_brollto create a uniquescene_assets_<id>_<rand>directory and pass it astemp_dirwhen invoking the composer, and importedInsight,SceneAssets,dispatch_scene, andcompose_videofrom the composer module.Testing
python -m compileall backend/services/podcast/broll_composer.py backend/services/podcast/broll_service.py, which succeeded.Codex Task