Skip to content

Use unique temp PNG paths and fix crossfade padding handling #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AJaySi wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −5
Open

Use unique temp PNG paths and fix crossfade padding handling #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions backend/services/podcast/broll_composer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
from pathlib import Path
from dataclasses import dataclass, field
from typing import Optional
import tempfile
import uuid
from PIL import Image, ImageDraw, ImageFont
import matplotlib
matplotlib.use("Agg")
Expand Down Expand Up @@ -40,7 +42,12 @@ def crossfade_concat(scenes: list, fade_dur: float = 0.5):
if i > 0:
c = c.fx(vfx.CrossFadeIn, fade_dur)
faded.append(c)
return concatenate_videoclips(faded, padding=-int(fade_dur), method="compose")
return concatenate_videoclips(faded, padding=-fade_dur, method="compose")


def _temp_png(prefix: str) -> str:
"""Create a unique temp PNG path to avoid concurrent render collisions."""
return str(Path(tempfile.gettempdir()) / f"{prefix}_{uuid.uuid4().hex}.png")


# ---------------------------------------------------------------------------
Expand Down Expand Up @@ -427,7 +434,7 @@ def build_data_scene(assets: SceneAssets, insight: Insight) -> CompositeVideoCli
.fx(vfx.fadeout, 0.4))
layers.append(chart)

card_path = "/tmp/insight_card.png"
card_path = _temp_png("insight_card")
make_insight_card(insight.key_insight, insight.supporting_stat, card_path)
card = (ImageClip(card_path)
.set_duration(d - 1)
Expand Down Expand Up @@ -460,7 +467,7 @@ def build_bullet_scene(assets: SceneAssets, insight: Insight,
bg = bg.fx(vfx.lum_contrast, 0, -50)
layers.append(bg)

bullet_path = "/tmp/bullets.png"
bullet_path = _temp_png("bullets")
make_bullet_overlay(bullets, bullet_path, width=860)
bullets_clip = (ImageClip(bullet_path)
.set_duration(d - 1)
Expand Down Expand Up @@ -498,7 +505,7 @@ def dispatch_scene(insight: Insight, assets: SceneAssets,
return build_full_avatar_scene(assets, insight)

elif cue in ("bar_comparison", "bar_chart_comparison", "bar_horizontal", "line_trend", "pie", "stacked_bar"):
chart_path = "/tmp/chart.png"
chart_path = _temp_png("chart")
chart_data = insight.chart_data or {}
if cue in ("bar_comparison", "bar_chart_comparison"):
# Normalize {labels, values} -> {labels, before, after} for make_bar_chart
Expand Down Expand Up @@ -620,4 +627,4 @@ def pipeline_from_json(insight_json: str,
})
print("\nSample Insight JSON:\n", sample_json)
print("\nAll asset generation tests passed.")
print("To run full video composition, supply real background_img and avatar_video paths.")
print("To run full video composition, supply real background_img and avatar_video paths.")
Loading