Encrypt WordPress OAuth tokens at rest with rollout-safe migration#489
Open
AJaySi wants to merge 1 commit into
Open
Encrypt WordPress OAuth tokens at rest with rollout-safe migration#489AJaySi wants to merge 1 commit into
AJaySi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
access_tokenandrefresh_tokenat rest using a managed key.Description
_initialize_fernet,_encrypt_token,_decrypt_token,_is_likely_encrypted_blob) with key lookup fromWORDPRESS_TOKEN_ENCRYPTION_KEYand fallback toOAUTH_TOKEN_ENCRYPTION_KEYand initialization in the service constructor.wordpress_oauth_tokenson OAuth callback and removed returning rawaccess_tokenin the callback response._migrate_plaintext_tokens_if_neededwhich detects plaintext rows and re-encryptsaccess_token/refresh_tokenon first-read, and integrated migration calls into token read paths to provide a one-time rollout migration.get_user_tokens) and added safe fallbacks to read plaintext until migrated; added error handling for decryption failures and avoided logging token values or code/state fragments.Testing
python -m py_compile backend/services/integrations/wordpress_oauth.pyand the module compiled successfully.Codex Task