Skip to content

chore: remove ck tensorwise pytest skip#334

Open
RuibinCheung wants to merge 1 commit into
mainfrom
fix/zhangrb/remove_pytest_skip
Open

chore: remove ck tensorwise pytest skip#334
RuibinCheung wants to merge 1 commit into
mainfrom
fix/zhangrb/remove_pytest_skip

Conversation

@RuibinCheung
Copy link
Copy Markdown
Collaborator

Description

Remove the pytest.skip guard that was unconditionally skipping CK and default (None) backends in test_grouped_gemm_fp8_tensorwise. The skip was originally added as a workaround for CK numerical issues which have since been resolved in newer hipcc as image upgrade to primus/26.2 .

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Remove the pytest.skip("CK backend has numerical issues currently") block in test_grouped_gemm_fp8_tensorwise that was skipping BackendType.CK and None (default) backends.
  • This re-enables tensorwise FP8 grouped GEMM test coverage for CK and default backend dispatch paths.

Checklist:

  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copilot AI review requested due to automatic review settings May 9, 2026 06:21
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

安全审查完成:未发现由本 PR 引入或暴露的中高危及以上漏洞。

本次变更仅删除 tests/pytorch/ops/test_grouped_gemm_fp8.py 中 CK/默认 backend 的 pytest skip,扩大测试执行覆盖;未修改生产代码、外部输入处理、认证/授权边界、日志、网络/文件访问或依赖。之前没有未解决的自动化安全审查线程需要重新报告。

Open in Web View Automation 

Sent by Cursor Automation: Find vulnerabilities

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-enables coverage for tensorwise FP8 grouped GEMM across CK and default (backend None) dispatch paths by removing an unconditional pytest.skip that was masking those backends.

Changes:

  • Removed the unconditional skip for BackendType.CK and backend=None in test_grouped_gemm_fp8_tensorwise.
  • Restored execution of tensorwise FP8 grouped GEMM tests for CK and default backend selection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants