Fix/enhance hunt mark poison barrier

[dsuchka]

No description provided.

[dsuchka]

Wait please, don't merge. I found a couple of bugs here and currently working on it. For instance: both enhance functions (early/later) are invoked before a card is played, so no enhance can be applied on a just played card (works only for next turns).

And it is still not working for Poison as expected (but works for Barrier, ofc except turns on which card is played).

[dsuchka]

Ok, for the Poison it's my bad, forgot to fix skill_names according to the enum changes.

For the early/later enhance bug: looks like the Fix::enhance_early is inverted, it works fine with no-fix-enhance-early.

[dsuchka]

But for the enabled Fix::enhance_early it's a totally strange behavior. Do we really need it? And do we really need all these Fix cases? Can we just simplify code for the current implementation with no outdated behaviors?

[APN-Pucky]

But for the enabled Fix::enhance_early it's a totally strange behavior. Do we really need it? And do we really need all these Fix cases? Can we just simplify code for the current implementation with no outdated behaviors?

I do not mind picking an implementation now. Originally, these were bugs in TU that I added to TUO as well, expecting TU to fix it at some point, but then development stopped.

[APN-Pucky]

For the early/later enhance bug: looks like the Fix::enhance_early is inverted, it works fine with no-fix-enhance-early.

Maybe they fixed it in the app/server. I did not follow recent (~year) updates.

[dsuchka]

For the early/later enhance bug: looks like the Fix::enhance_early is inverted, it works fine with no-fix-enhance-early.

Maybe they fixed it in the app/server. I did not follow recent (~year) updates.

Damn, it was 6 years ago [commit ca8e9c6] and it was 1st fix, the Fixes started from it! No idea how it was at those days. For now it works as should (as far as I see). So, we can just default Fix::enhance_early to false to fix the issue.

[APN-Pucky]

I guess it is good to attach this here for future reference. I have never seen them implement or announce that a bug was fixed. So maybe I should revise all the fixes.

[dsuchka]

Just checked it in the game for Barrier and Poison: Barrier don't get enhanced at turn it's played, but Poison/Armor do. So, we have different behavior for different defensive skills, and it can't be fixed only by toggling fix::enhance_early flag.

[dsuchka]

I've checked almost all defensive, instant-debuff, and triggered skills.
- means the game has bug (and fix::enhance_early fixes it, TUO has the same effect with the fix)
+ means the game has correct behavior (no fix::enhance_early needed here)
? means I don't know :)

[Defensive]
Armor +
Avenge -
Scavenge +
Corrosive +
Counter +
Evade +
Subdue +
Absorb -
(Flying is non-enhanceable)
Payback ? [no cards enhance it, can't check]
Revenge ? [only raid cards enhance it]
Tribute ? ["Tabitha's Huntsman" can help to check]
Refresh ? ["Tartarian Mollusk", "Alpha Regenerator" can help to check]
(Wall is non-enhanceable)
Barrier -
Poison +

[Instant-Debuff]
Inhibit -
Sabotage ? ["Alpha Impostor" can help to check]
Disease -

[Triggered]
Allegiance - [no bug here, by design Allegiance works only for previously played cards, never for itself]
Valor ? [no cards enhance it, can't check]
(Flurry is non-enhanceable)
Stasis -
(Summon is non-enhanceable)
Bravery ? [no cards enhance it, can't check]
(Enhance is non-enhanceable)

[APN-Pucky]

Why is poison defensive? I'd group it with hunt and mark. Or if it is just to get the right behavior for enhance. Maybe we add a comment to avoid confusion here?