Feature/complete remaining#11
Merged
Merged
Conversation
…ith metrics
- Replace ${DS_PROMETHEUS} template vars with literal 'Prometheus' datasource name
(provisioned dashboards don't resolve __inputs substitution)
- Change stat panel colorMode from 'background' to 'value' (removes green blocks)
- Add metrics.CommandsTotal and CommandDurationSeconds instrumentation to
handleSetKey and handleGetKey so latency heatmap and p99 panels get data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the final remaining work on the project across three areas.
Changes
Prometheus + Grafana monitoring
prometheus.ymlscrapes/metricsfrom all 3 Raft nodes every 5sdocker-compose.yml— Prometheus on:9090, Grafana on:300116-shard concurrent store
sync.RWMutex + mapwith 16 independent shardsgo test -raceREADME
Benchmark results (i7-12650H, 16 cores)