Skip to content

Respect disabled shipped personas #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Martinnn674 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Respect disabled shipped personas #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rooms/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def get_default_personas(settings: RoomsSettings) -> List[AgentConfig]:
return [persona_settings_to_agent_config(p, settings.defaults) for p in settings.personas]
if settings.use_shipped_personas:
return _shipped_persona_dicts_to_configs(settings.defaults)
return _shipped_persona_dicts_to_configs(settings.defaults)
return []


def resolve_preset_model(settings: RoomsSettings, preset_name: str) -> str:
Expand Down
6 changes: 6 additions & 0 deletions tests/test_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ def test_shipped_personas_use_defaults_model():
assert personas[0].name == "Elena (The Lawyer)"


def test_empty_personas_respects_disabled_shipped_personas():
settings = RoomsSettings(use_shipped_personas=False)
personas = get_default_personas(settings)
assert personas == []


def test_custom_personas_from_yaml():
settings = RoomsSettings(
use_shipped_personas=False,
Expand Down