Fix driverinfo retrieval to handle empty cases#27
Open
mworion wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates DriverInfo to provide a default value when the driverinfo field is missing, avoiding errors from calling .split() on None.
Changes:
- Adds a default empty-string fallback to
self._get("driverinfo", "")inDriverInfo.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, many thanks for this nice package. I move completely to this solution recently in my application.
I interface with NINA (as they offer all devices as ALPACA devices through a plugin).
In case of some devices they are not filling the device.info field. The conformance checker does not raise an issue about it.
If there is no field populated, get will return NONE. From implementation this could happen.
If doing a split to none, python raises an exception. This could be corrected by giving a default value of an empty string.
If an empty device.info is right or incorrect I do not address, simply only the robustness of the python implementation.
Michel