fix: allow Bing engine to follow HTTP redirects (301)#95
Open
XVOYOVX wants to merge 1 commit into
Open
Conversation
cn.bing.com returns a 301 redirect to www.bing.com, but the Bing engine was configured with `trustedStaticHost: true`, which forces `maxRedirects: 0` in the HTTP request layer. This caused all Bing searches to fail with a timeout error for users behind proxies or in regions where cn.bing.com redirects. Changed `trustedStaticHost` from `true` to `false` so that Bing requests follow redirects (up to 5 hops by default), matching the behavior of other search engines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bing searches fail with a timeout when
cn.bing.comreturns a 301 redirect towww.bing.com. This affects users behind proxies or in regions wherecn.bing.comredirects.Root Cause
In
src/engines/bing/bing.ts, thebuildBingAxiosRequestOptions()function setstrustedStaticHost: true. Insrc/utils/httpRequest.ts, this forcesmaxRedirects: 0, preventing the HTTP client from following any redirects.cn.bing.com/searchreturns a301 → www.bing.com, but withmaxRedirects: 0the request fails silently and eventually times out.Fix
Changed
trustedStaticHost: truetotrustedStaticHost: falseinbuildBingAxiosRequestOptions(), allowing Bing requests to follow redirects (up to 5 hops by default), consistent with the behavior offetchWebContent.Testing
Verified locally: after the fix,
open-websearch search "test" --engine bingreturns results successfully instead of timing out.