Allow specifying starting offsets via the Kafka source options.#719
Allow specifying starting offsets via the Kafka source options.#719
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughKafkaAvroSource now reads default offset bounds from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@pramen/extras/src/main/scala/za/co/absa/pramen/extras/source/KafkaAvroSource.scala`:
- Around line 171-172: The lookup in KafkaAvroSource.scala (case None branch)
uses the wrong key and therefore always defaults to "earliest"; change the
lookup against kafkaAvroConfig.extraOptions to use the prefixed key
"kafka.startingOffsets" (but keep the returned Map key as "startingOffsets") so
user-configured kafka.startingOffsets is respected when building the Map for
startingOffsets.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6d2bff03-6937-40e8-8dde-74457dc117cc
📒 Files selected for processing (1)
pramen/extras/src/main/scala/za/co/absa/pramen/extras/source/KafkaAvroSource.scala
pramen/extras/src/main/scala/za/co/absa/pramen/extras/source/KafkaAvroSource.scala
Outdated
Show resolved
Hide resolved
c68ffb7 to
f0efffa
Compare
Unit Test Coverage
Files
|
f0efffa to
f60ef75
Compare
Summary by CodeRabbit