fix(buckets): show phone icon for Android devices in Raw Data view#905
Merged
ErikBjare merged 1 commit intoJul 12, 2026
Conversation
The mobile icon was imported but never used — all devices showed the desktop icon regardless of type. Use bucketsStore.available().android (same detection as Activity.vue after ActivityWatch#903) to select mobile vs desktop.
Contributor
Greptile SummaryThis PR updates the Raw Data device icon selection in
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(buckets): show phone icon for Androi..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #905 +/- ##
=======================================
Coverage 38.55% 38.55%
=======================================
Files 42 42
Lines 2233 2233
Branches 444 444
=======================================
Hits 861 861
Misses 1294 1294
Partials 78 78 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
mobileicon was imported inBuckets.vuebut never used. All devicesin the Raw Data view showed a desktop icon, even Android phones.
Fix
Add a
v-else-ifthat usesbucketsStore.available(device.hostname).android(same runtime detection introduced in Activity.vue by #903) to render the
mobileicon for Android devices, withdesktopas the fallback.The hostname column was already removed in #903 (grouped-by-device context
made it redundant). This PR covers the remaining Raw Data view gap.
Behaviour
Requested by ErikBjare in ActivityWatch/aw-android#176.