-
Notifications
You must be signed in to change notification settings - Fork 47
Time - Mair H #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Time - Mair H #23
Conversation
…te html.erb for index and show
…nput a new task and submit the form- end of wave 2 with all tests passing
…on to remove a task
…ks to adjust to the testing requirements
…e changes to all files except for the tests
… resources :tasks now
Task ListMajor Learning Goals/Code Review
Functional Requirements/Manual Testing
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
kaidamasaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Just have one tip for future projects. 😃
| create_table :tasks do |t| | ||
| t.string :name | ||
| t.string :description | ||
| t.string :completed_at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future you should use t.datetime for columns like this.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions