Maple - Detroit#75
Open
Detroit-the-Dev wants to merge 8 commits into
Open
Conversation
…react-tic-tac-toe into digital-starter
tgoslee
reviewed
Jan 11, 2022
Comment on lines
+38
to
+41
| if (turn % 2 !== 0) { | ||
| return PLAYER_1; | ||
| } else { | ||
| return PLAYER_2; |
There was a problem hiding this comment.
you could refactor here and use a ternary operator
tgoslee
reviewed
Jan 11, 2022
| } | ||
| } | ||
| let checkedWinner = checkForWinner(); | ||
| console.log(checkedWinner); |
tgoslee
reviewed
Jan 11, 2022
| <h1>React Tic Tac Toe</h1> | ||
| <h2>The winner is ... -- Fill in for wave 3 </h2> | ||
| <button>Reset Game</button> | ||
| <h2>Winner is {winner}</h2> |
There was a problem hiding this comment.
When there isn't a winner you could display who the current player is. Like "Its Player 1's turn" or "It's X's turn"
|
Good Tiana! I only had a few comments to add :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.