refactor: Cleanup ComplexSet code layout and skeletonize its JSDoc's.#1284
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 2/5
- In
scripts/scr_ComplexSet/scr_ComplexSet.gml, the defaultassign_modulars()behavior appears to clear each modular item's position, soglobal.modular_drawing_itemsare no longer added to the ComplexSet and modular visuals may silently disappear at runtime; only override position when a caller explicitly provides one (such as weapon visual overrides) before merging.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
5498088 to
cf4d93a
Compare
cf4d93a to
c401e98
Compare
EttyKitty
reviewed
Jun 30, 2026
c401e98 to
8e3e9dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added barebones JSDoc styling where i could in ComplexSet and tangentally scr_population_influence as well. I did slip in a few code changes here and there as they caught my eye but nothing that should cause a regression.
In ComplexSet I also rearranged things so all variable definitions are at the top of the file instead of interspersed throughout.
Summary by cubic
Reorganized
ComplexSetinto a clean top‑to‑bottom layout and expanded lightweight JSDoc across its API andscr_population_influence. Improves readability, type hints, and maintainability without changing expected behavior.Refactors
@param,@return, and@selfJSDoc acrossComplexSetmethods; typed helpers likescr_has_style,valid_sprite_transform_data, andsprite_get_uvs_transformed.global.base_component_surfaceup front; callbase_armour()before Techmarine overlays.assign_modulars: useposition = ""to opt‑in override; simplified style checks and array early‑exit.Bug Fixes
merge_influences: passidintoadjust_influenceand updated@selftoAsset.GMObject.obj_star.assign_modulars: respect providedpositionfor non‑weapon items so they render in the right area.Written for commit f880d0f. Summary will update on new commits.