Conversation
…ts completion The dashboard health score tracks the "drivers" tool via history entries, but a history entry was only created when stale packages were cleaned — never after a scan-only check. This meant scanning for driver updates (even successfully with no updates needed) left the dashboard showing drivers as incomplete. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68a4074b8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| final.setHasScanned(true) | ||
|
|
||
| // Record scan in history so dashboard reflects completion | ||
| if (staleResult.status === 'fulfilled' || updateResult.status === 'fulfilled') { |
There was a problem hiding this comment.
This condition records a drivers history entry even when only one of the two scans succeeds, but the entry is written as a clean success (errorCount: 0), so the dashboard/history can report the driver tool as completed despite a visible scan failure toast. In a partial-failure run (e.g., stale scan fails, update scan succeeds), this produces inaccurate completion and reliability signals; the history write should require full success or include the failure in the recorded result.
Useful? React with 👍 / 👎.
| totalItemsSkipped: 0, | ||
| totalSpaceSaved: 0, | ||
| categories: [ | ||
| ...(staleCount > 0 ? [{ name: 'Stale Drivers', itemsFound: staleCount, itemsCleaned: 0, spaceSaved: staleSize }] : []), |
There was a problem hiding this comment.
Using staleSize as spaceSaved for a scan-only entry reports unrecovered bytes as recovered bytes. HistoryPage aggregates category.spaceSaved into category charts, so these entries can incorrectly rank “Stale Drivers” as recovered space even when no cleanup happened (totalSpaceSaved is 0). For scan entries, category spaceSaved should remain 0 to keep history metrics consistent.
Useful? React with 👍 / 👎.
1 participant
Summary
handleScanrecords adrivershistory entry after successful completion, so the dashboard correctly highlights drivers as doneTest plan
🤖 Generated with Claude Code