Skip to content

fix: writing assistant live region scope #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
web3blind wants to merge 1 commit into from
Closed

fix: writing assistant live region scope #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions content_scripts/toneTranslator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ function mtBuildPanel() {
panel.id = 'mt-panel';
panel.setAttribute('role', 'complementary');
panel.setAttribute('aria-label', 'MindTab Writing Assistant');
panel.setAttribute('aria-live', 'polite');
panel.innerHTML = `
<div id="mt-panel-head">
<span id="mt-panel-title">⚡ MindTab <span id="mt-srv-dot" class="none" title="Grammar server status"></span></span>
Expand All @@ -265,7 +264,7 @@ function mtBuildPanel() {
<span id="mt-tone-label">Tone</span>
<span id="mt-tone-val">—</span>
</div>
<div id="mt-suggestions"></div>
<div id="mt-suggestions" aria-live="polite" aria-atomic="false"></div>
<div id="mt-lt-section">
<h4>Grammar &amp; Spelling</h4>
<div id="mt-lt-issues"></div>
Expand Down
14 changes: 14 additions & 0 deletions tests/toneTranslatorAccessibility.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { describe, expect, it } from 'vitest';
import { readFileSync } from 'node:fs';

const source = readFileSync(new URL('../content_scripts/toneTranslator.js', import.meta.url), 'utf8');

describe('writing assistant accessibility live regions', () => {
it('does not make the entire panel a live region', () => {
expect(source).not.toContain("panel.setAttribute('aria-live', 'polite')");
});

it('scopes polite announcements to the suggestions container', () => {
expect(source).toContain('id="mt-suggestions" aria-live="polite" aria-atomic="false"');
});
});
Loading